[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2] build: Build synopsis.c before main.c



On Sun, Aug 19, 2018 at 12:47:52AM +0300, Nir Soffer wrote:
> On Sun, Aug 19, 2018 at 12:43 AM Richard W.M. Jones <rjones redhat com>
> wrote:
> 
> > From: Nir Soffer <nirsof gmail com>
> >
> > synopsis.c was defined as dependency of the nbdkit program, but it
> > should be define as dependency of main.c. Otherwise "make" fail with:
> >
> > main.c:180:10: fatal error: synopsis.c: No such file or directory
> >  #include "synopsis.c"
> >           ^~~~~~~~~~~~
> >
> > Fixes commit 445e18f3dbb2 (src, docs: Generate the nbdkit command
> > synopsis from a single source).
> > ---
> >  src/Makefile.am | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 5c67bf8..6b9e0a9 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -77,10 +77,11 @@ nbdkit_LDFLAGS = \
> >         -rdynamic
> >
> >  # synopsis.c is generated from docs/synopsis.txt where it is also
> > -# used to generate the man page.
> > +# used to generate the man page.  It is included in main.c.
> >
> 
> Looks good, but now we have 2 place to edit if we include this
> in another source.

I guess we'll worry about that if it happens.  Thanks, I have
pushed it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]