[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 1/4] file: Avoid unsupported fallocate() calls



On Sun, Aug 19, 2018 at 5:34 PM Eric Blake <eblake redhat com> wrote:
On 08/18/2018 03:09 PM, Nir Soffer wrote:
> On Mon, Aug 13, 2018 at 11:58 PM Nir Soffer <nsoffer redhat com> wrote:
>
>> On Mon, Aug 13, 2018 at 8:44 PM Eric Blake <eblake redhat com> wrote:
>>
>>>>    #ifdef FALLOC_FL_ZERO_RANGE
>>>> -  r = do_fallocate (h->fd, FALLOC_FL_ZERO_RANGE, offset, count);
>>>> -  if (r == -1 && errno != EOPNOTSUPP) {
>>>> -    nbdkit_error ("zero: %m");
>>>> +  if (h->can_zero_range) {
>>>> +    r = do_fallocate (h->fd, FALLOC_FL_ZERO_RANGE, offset, count);
>>>> +    if (r== 0)
>>>
>>> Spacing is off.
>>>
>>
> It does look off in my mail client (inbox), but looks fine (2 spaces
> indentation)
> in my editor.

Not the leading spaces, but the asymmetric space around '=='.

Thanks, got it finally :-)
 
(Yes,
Thunderbird is known to have a display bug where lines prefixed with
space show at a different indentation levels than lines prefixed with -
or +, which makes patch review via Thunderbird a bit more awkward than
it should be - but that's not what I was complaining about)


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]