[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] generator: Do not claim copyright for future years



On Wed, Aug 22, 2018 at 05:52:10AM +0200, Bernhard M. Wiedemann wrote:
> This change helps to make libguestfs package build reproducible.
> See https://reproducible-builds.org/ for why this is good.
> 
> Without this patch, building today's libguestfs in 2033, claims
>  Copyright (C) 2009-2033 Red Hat Inc.
> which cannot be correct.
> 
> This affected files like
> /usr/include/guestfs-gobject.h
> /usr/lib/perl5/vendor_perl/5.26.2/x86_64-linux-thread-multi/Sys/Guestfs.pm
> /usr/lib64/python2.7/site-packages/guestfs.py
> /usr/lib64/ocaml/guestfs/guestfs.mli
> 
> Commits like 212762c59351822e9db7d3dc82afe1765808d918
> will take care of updating the year.
> ---
>  generator/docstrings.ml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/generator/docstrings.ml b/generator/docstrings.ml
> index fa7b1668a..b480d036e 100644
> --- a/generator/docstrings.ml
> +++ b/generator/docstrings.ml
> @@ -68,9 +68,7 @@ let version_added = function
>      Some (sprintf "%d.%d.%d" major minor release)
>    | _ -> None
>  
> -let copyright_years =
> -  let this_year = 1900 + (localtime (time ())).tm_year in
> -  if this_year > 2009 then sprintf "2009-%04d" this_year else "2009"
> +let copyright_years = "2009-2018"

Thanks, will push this shortly.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]