[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] build: Pass CFLAGS & LDFLAGS to final supermin link (RHBZ#1624175).



On Friday, 31 August 2018 10:03:31 CEST Richard W.M. Jones wrote:
> We also use -runtime-variant _pic which selects the OCaml runtime
> linked with -fPIC.  This will cause a performance regression on i686
> although that probably doesn't matter now.

This is for supermin, right?

> A bigger issue is that it will stop supermin from building with older
> versions of OCaml (<= 4.02.2).  We might instead try detecting if it's
> the old version in ./configure but that gets a bit fragile.

The latest commit in supermin is
5c5eff66dfaccb212b8906e769e40633d8b8f5e4, which basically already
raised the OCaml build requirement to >= 4.02.0.

Because of that, I'd say this LGTM.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]