[Libguestfs] [nbdkit PATCH] maint: Adjust cleaning rules

[Richard W.M. Jones]

On Thu, Dec 13, 2018 at 08:55:41AM -0600, Eric Blake wrote:
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 4c7b59c..55db593 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -32,7 +32,8 @@
> 
>  include $(top_srcdir)/common-rules.mk
> 
> -MAINTAINERCLEANFILES =
> +CLEANFILES =

Because common-rules.mk defines CLEANFILES, this should be giving a
warning.  And also because of that ...

> +CLEANFILES += \
> +	test_ocaml_plugin.cmx \
> +	test_ocaml_plugin.cmi \
> +	test-ocaml-plugin.so

... this should not be necessary because the CLEANFILES rule in
common-rules.mk cleans these files already.

If that is fixed, ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top