[Libguestfs] [PATCH nbdkit 2/4] valgrind: Add --show-leak-kinds=all and comprehensive list of suppressions.

[Eric Blake]

On 12/3/18 1:01 PM, Richard W.M. Jones wrote:

> 
>>>       passthru ("--error-exitcode=119");
>>> -    passthru_format ("--suppressions=%s/valgrind-suppressions", srcdir);
>>> +    passthru_format ("--suppressions=%s/valgrind/suppressions", builddir);
>>
>> Is this still right under VPATH?
> 
> I believe so ...?  Note this is the generated/concatenated file which
> is why I changed srcdir to builddir.

Yes, if it's generated, then builddir should be right.  But this is an 
independent fix, so I might have split it to another patch. (I guess I 
haven't got that far in my ongoing VPATH cleanups; up to now, my VPATH 
fixes have been the ones for issues pointed out by 'make distcheck', 
which doesn't run valgrind, as opposed to an actual VPATH build myself).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org