[Libguestfs] [PATCH nbdkit 2/4] valgrind: Add --show-leak-kinds=all and comprehensive list of suppressions.

Richard W.M. Jones rjones at redhat.com
Mon Dec 3 19:18:14 UTC 2018


On Mon, Dec 03, 2018 at 01:11:07PM -0600, Eric Blake wrote:
> On 12/3/18 1:01 PM, Richard W.M. Jones wrote:
> 
> >
> >>>      passthru ("--error-exitcode=119");
> >>>-    passthru_format ("--suppressions=%s/valgrind-suppressions", srcdir);
> >>>+    passthru_format ("--suppressions=%s/valgrind/suppressions", builddir);
> >>
> >>Is this still right under VPATH?
> >
> >I believe so ...?  Note this is the generated/concatenated file which
> >is why I changed srcdir to builddir.
> 
> Yes, if it's generated, then builddir should be right.  But this is
> an independent fix, so I might have split it to another patch. (I
> guess I haven't got that far in my ongoing VPATH cleanups; up to
> now, my VPATH fixes have been the ones for issues pointed out by
> 'make distcheck', which doesn't run valgrind, as opposed to an
> actual VPATH build myself).

Right, but before this patch valgrind-suppressions wasn't generated, so
using srcdir was correct.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list