[Libguestfs] [PATCH] v2v: -o rhv-upload: Fix emulated zero

[Nir Soffer]

On Fri, Dec 7, 2018 at 8:50 PM Richard W.M. Jones <rjones at redhat.com> wrote:

> On Fri, Dec 07, 2018 at 07:55:28PM +0200, Nir Soffer wrote:
> > Replace python 2 only "buffer" with "memoryview".
> >
> > Falling back to emulated zero would fail with:
> >
> >     NameError: name 'buffer' is not defined
> >
> > I did not test the changed code but it was not tested before so it is
> > unlikely to be worse.
> >
> > Detected by pylint.
>
> Thanks - I pushed both.
>
> I wonder how the pread method worked before?  That's on the main path
> I think.
>

I never seen a READ request on imageio log, so it seems that qemu-img
convert
never read from the destination.

Nir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20181207/789c8c9e/attachment.htm>