[Libguestfs] [PATCH] Add a cache for iconv_t handles to hive_t

[Richard W.M. Jones]

On Sat, Feb 10, 2018 at 01:40:36AM +0100, Hilko Bengen wrote:
> * Richard W.M. Jones:
> 
> >> +threadlib
> >>  '
> >
> > Probably better to keep these sorted.
> 
> When I rebuilt from scratch, it turned out that threadlib was not
> enough. Using the "lock" module with the gl_lock_{init,lock,unlock}
> instead of glthread_lock_{init,lock,unlock} as described in lock.h seems
> correct, though. I have pushed that change.
> 
> > I wonder if there's a way we can avoid hard-coding ‘4’ here, which
> > AIUI is the size of the enum type.  Maybe adding an extra enum case
> > ‘nr_recode_types’?
> 
> Sure, done.

Great, thanks.

I'm going to do a 1.3.15 release soonish.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org