[Libguestfs] [PATCH nbdkit v2 2/3] Refactor plugin_* functions into a backend struct.

Richard W.M. Jones rjones at redhat.com
Tue Jan 16 20:39:56 UTC 2018


On Tue, Jan 16, 2018 at 10:56:25AM -0600, Eric Blake wrote:
> Is it worth using 'bool' instead of 'int' where we are really using a
> truth value?  We can't change the nbdkit-plugin.h API (well, at least
> not without plugins opting in), but the new stuff (including filters)
> could be sane from the get-go instead of overloading int.

I wonder if there's any point to changing these to bool.  It'll mean
that internal APIs use unnecessarily different types, and I don't know
what the advantages are.  Of course it might have been better if we'd
used bool from the start ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list