[Libguestfs] [PATCH] lib: docs: State that guestfs_list_filesystems is no longer requires to be used soon after launch when nothing is mounted

Richard W.M. Jones rjones at redhat.com
Tue Jan 23 10:29:39 UTC 2018


On Tue, Jan 23, 2018 at 11:37:26AM +0200, Mykola Ivanets wrote:
> guestfs_list_filesystems uses mount/umount to discover btrfs sub-volumes and since 1.37 it generates random mountpoint so it will longer affect already mounted filesystems if either.
> ---
>  generator/actions_core.ml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/generator/actions_core.ml b/generator/actions_core.ml
> index ed8cb16..9a695c0 100644
> --- a/generator/actions_core.ml
> +++ b/generator/actions_core.ml
> @@ -9674,7 +9674,8 @@ content of the device is undetermined or empty.
>  
>  This command runs other libguestfs commands, which might include
>  C<guestfs_mount> and C<guestfs_umount>, and therefore you should
> -use this soon after launch and only when nothing is mounted.
> +use this soon after launch and only when nothing is mounted
> +(it is no longer a requirement since 1.37).
>  
>  Not all of the filesystems returned will be mountable.  In
>  particular, swap partitions are returned in the list.  Also
> -- 
> 2.9.5

I made some small adjustments to the language to make it read
a little more clearly and pushed it.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list