[Libguestfs] [PATCH nbdkit] Change the default protocol to newstyle.

Eric Blake eblake at redhat.com
Tue Jan 23 20:19:05 UTC 2018


On 01/23/2018 01:04 PM, Richard W.M. Jones wrote:
> nbdkit <= 1.1.28 defaulted to the oldstyle protocol for compatibility
> with qemu and libguestfs.  However qemu >= 2.6 can now work with
> either protocol and is widely installed.  Also newstyle is required
> for newer features such as export names and TLS.  In addition
> nbd-client dropped support for oldstyle entirely.
> 
> You can select the oldstyle protocol by adding ‘-o’, and it is still
> tested.

Looks right to me.

> ---
>  TODO                 |  6 ++++++
>  docs/nbdkit.pod      | 29 +++++++++++++++--------------
>  src/main.c           |  2 +-
>  tests/test-single.sh |  2 +-
>  4 files changed, 23 insertions(+), 16 deletions(-)

(Yay - my test-nbd was already set up for proper explicit use of -o vs.
-n, so it still covers both styles regardless of the default)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20180123/8640704c/attachment.sig>


More information about the Libguestfs mailing list