[Libguestfs] [PATCH] daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)

Pino Toscano ptoscano at redhat.com
Tue Jan 30 18:36:18 UTC 2018


On Tuesday, 30 January 2018 18:29:13 CET Richard W.M. Jones wrote:
> On Tue, Jan 30, 2018 at 06:24:19PM +0100, Pino Toscano wrote:
> > --- a/docs/guestfs-building.pod
> > +++ b/docs/guestfs-building.pod
> > @@ -178,7 +178,7 @@ I<Required>.
> >  I<Required> if compiling from git.
> >  Optional if compiling from tarball.
> >  
> > -=item hivex E<ge> 1.3.14
> > +=item hivex
> 
> It really works with any version of hivex now?

I cannot really test it on any version", although my patch worked with
hivex 1.3.8 and 1.3.13.  I can restore the previous version though,
which was 1.2.7 before 64f49df747c0937d9433eb11d4191d92a4af748c.

> I appreciate the thought and effort in this patch, but maybe
> it's easier to get people to upgrade hivex to a more recent
> version.

In case of a C library is easy; OTOH deploying a new OCaml module, and
make it available to ocamlfind does not seem an easy task.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20180130/2227dfb6/attachment.sig>


More information about the Libguestfs mailing list