[Libguestfs] [PATCH] v2v: -o rhv-upload: PEP8 fixes for rhv-upload-plugin.py
Richard W.M. Jones
rjones at redhat.com
Tue Jul 31 20:08:26 UTC 2018
On Tue, Jul 31, 2018 at 06:58:25PM +0200, Pino Toscano wrote:
> - wrap a too long line
> - join strings in multiple lines using + (plus) instead of \ (backslash)
> ---
> v2v/rhv-upload-plugin.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
> index 4fad27fb8..bdc1e104a 100644
> --- a/v2v/rhv-upload-plugin.py
> +++ b/v2v/rhv-upload-plugin.py
> @@ -86,7 +86,8 @@ def find_host(connection):
>
> hosts_service = system_service.hosts_service()
> hosts = hosts_service.list(
> - search="hw_id=%s and datacenter=%s and status=Up" % (vdsm_id, datacenter.name),
> + search="hw_id=%s and datacenter=%s and status=Up"
> + % (vdsm_id, datacenter.name),
> case_sensitive=True,
> )
> if len(hosts) == 0:
> @@ -94,8 +95,8 @@ def find_host(connection):
> # - 'hw_id' equals to 'vdsm_id'
> # - Its status is 'Up'
> # - Belongs to the storage domain's datacenter
> - debug("cannot find a running host with hw_id=%r, " \
> - "that belongs to datacenter '%s', " \
> + debug("cannot find a running host with hw_id=%r, " +
> + "that belongs to datacenter '%s', " +
> "using any host" % (vdsm_id, datacenter.name))
> return None
ACK. These sort of simple tidy-ups are fine to push without review.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
More information about the Libguestfs
mailing list