[Libguestfs] [PATCH] v2v: Set machine type explicitly for outputs which support it (RHBZ#1581428).

[Richard W.M. Jones]

On Tue, Jun 19, 2018 at 12:39:06PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 19, 2018 at 12:12:30PM +0100, Richard W.M. Jones wrote:
> > On Tue, Jun 19, 2018 at 11:43:38AM +0100, Daniel P. Berrangé wrote:
> > > I'd encourage apps to check the capabilities XML to see what
> > > machine types are available.
> > 
> > One issue is we don't always have access to the target hypervisor.
> > 
> > For example in the Glance case we have to write something which will
> > be picked up by Nova much later:
> > 
> > > > +        "hw_machine_type",
> > > > +        (match guestcaps.gcaps_machine with
> > > > +         | I440FX -> "pc"
> > > > +         | Q35 -> "q35"
> > > > +         | Virt -> "virt");
> > 
> > I read the Nova code and it seems very ad-hoc.  As far as I can tell
> > these strings are eventually passed down to libvirt.  However libvirt
> > capabilities doesn't advertise these machine types exactly, but
> > something more like "pc-q35-2.6".  Does libvirt map "q35" to something
> > intelligent?
> 
> It'll report both - one as an alias of the other
> 
> eg
> 
>       <machine canonical='pc-i440fx-2.11' maxCpus='255'>pc</machine>
>       <machine canonical='pc-q35-2.11' maxCpus='288'>q35</machine>

Oh I see, I missed that in all the output.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v