[Libguestfs] [PATCH] v2v: rhv-upload-plugin: Optimize only direct upload

Nir Soffer nirsof at gmail.com
Fri Jun 29 22:39:03 UTC 2018


The optimization to start the transfer on the local host makes sense
only when using the rhv-direct=true option. When using a proxy, let the
engine choose a host.
---
 v2v/rhv-upload-plugin.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 8805e3552..1404ed1f5 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -143,8 +143,8 @@ def open(readonly):
     # Get a reference to the transfer service.
     transfers_service = system_service.image_transfers_service()
 
-    # Create a new image transfer.
-    host = find_host(connection)
+    # Create a new image transfer, using the local host is possible.
+    host = find_host(connection) if params['rhv_direct'] else None
     transfer = transfers_service.add(
         types.ImageTransfer(
             disk = types.Disk(id = disk.id),
-- 
2.17.1




More information about the Libguestfs mailing list