[Libguestfs] [nbdkit PATCH v3 05/15] filters: Add blocksize filter

Eric Blake eblake at redhat.com
Tue Mar 20 15:30:14 UTC 2018


On 03/08/2018 05:03 PM, Eric Blake wrote:
> Testing is easy by reusing the log filter and observing that
> requests were rewritten as expected (well, with the slight
> complication that different versions of qemu-io vary in whether
> they obey the NBD spec of limiting themselves to 512-byte I/O
> if we don't advertise otherwise with NBD_OPT_GO, or in just
> directly handing us byte-based I/O anyway - so the test has
> to round to something even bigger to be sure it sees a
> difference).
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> 

> +++ b/tests/test-blocksize.sh
> @@ -0,0 +1,156 @@
> +#!/bin/bash -
> +# nbdkit
> +# Copyright (C) 2018 Red Hat Inc.

> +
> +: ${QEMU_IO=qemu-io}

Your pending patch to remove QEMU_IO/HAVE_QEMU_IO impacts whether I 
should do this, or just rely on a PATH override (I can rebase this and 
similar patches on top of your cleanup if you want to push that first)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list