[Libguestfs] [PATCH v7 5/6] v2v: Make the vddk_options and vdsm_options abstract.

Richard W.M. Jones rjones at redhat.com
Thu Mar 22 15:24:24 UTC 2018


Since the contents of these structures are no longer used outside the
Input_libvirt_vddk and Output_vdsm modules respectively, we can make
both structures into abstract data types.
---
 v2v/input_libvirt_vddk.mli | 2 +-
 v2v/output_vdsm.mli        | 9 +--------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/v2v/input_libvirt_vddk.mli b/v2v/input_libvirt_vddk.mli
index ee2d6651a..96bfea0e9 100644
--- a/v2v/input_libvirt_vddk.mli
+++ b/v2v/input_libvirt_vddk.mli
@@ -18,7 +18,7 @@
 
 (** [-i libvirt] when the source is VMware via nbdkit vddk plugin *)
 
-type vddk_options = (string * string) list
+type vddk_options
 (** Various options passed through to the nbdkit vddk plugin unmodified. *)
 
 val print_vddk_input_options : unit -> unit
diff --git a/v2v/output_vdsm.mli b/v2v/output_vdsm.mli
index 90ce8736c..7596a83ab 100644
--- a/v2v/output_vdsm.mli
+++ b/v2v/output_vdsm.mli
@@ -18,14 +18,7 @@
 
 (** [-o vdsm] target. *)
 
-type vdsm_options = {
-  image_uuids : string list;          (* --vdsm-image-uuid (multiple) *)
-  vol_uuids : string list;            (* --vdsm-vol-uuid (multiple) *)
-  vm_uuid : string;                   (* --vdsm-vm-uuid *)
-  ovf_output : string;                (* --vdsm-ovf-output *)
-  compat : string;                    (* --vdsm-compat=0.10|1.1 *)
-  ovf_flavour : Create_ovf.ovf_flavour;
-}
+type vdsm_options
 (** Miscellaneous extra command line parameters used by VDSM. *)
 
 val print_vdsm_output_options : unit -> unit
-- 
2.13.2




More information about the Libguestfs mailing list