[Libguestfs] [PATCH v7 3/6] v2v: cmdline: Factor out global variable.

[Pino Toscano]

On Thursday, 22 March 2018 16:24:22 CET Richard W.M. Jones wrote:
> ---
>  v2v/cmdline.ml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/v2v/cmdline.ml b/v2v/cmdline.ml
> index 70e9a3c3b..6aecd2aee 100644
> --- a/v2v/cmdline.ml
> +++ b/v2v/cmdline.ml
> @@ -48,6 +48,8 @@ type cmdline = {
>    root_choice : root_choice;
>  }
>  
> +let ovf_flavours_str = String.concat "|" Create_ovf.ovf_flavours
> +
>  let parse_cmdline () =
>    let compressed = ref false in
>    let debug_overlays = ref false in
> @@ -83,7 +85,6 @@ let parse_cmdline () =
>    let set_vdsm_compat s = vdsm_compat := s in
>  
>    let vdsm_ovf_flavour = ref Create_ovf.RHVExportStorageDomain in
> -  let ovf_flavours_str = String.concat "|" Create_ovf.ovf_flavours in
>    let set_vdsm_ovf_flavour arg =
>      vdsm_ovf_flavour := Create_ovf.ovf_flavour_of_string arg in

Is it really used as global variable?

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20180323/f5c6d995/attachment.sig>