[Libguestfs] [PATCH FOR DISCUSSION ONLY v2] v2v: Add -o kubevirt output mode.

Richard W.M. Jones rjones at redhat.com
Thu Mar 29 15:40:55 UTC 2018


On Thu, Mar 29, 2018 at 05:26:13PM +0200, Piotr Kliczewski wrote:
> Richard,
> 
> Great progress. I really like it!!!
> 
> Here is what I noticed:
> 
> I see that in the yaml file we provide short-id as:
> 
>   os:
>     osinfo: 'rhel7.2'
> 
> whereas kubevirt expects it in metadata:
> 
> metadata:
>   labels:
>     kubevirt.io/os: win10
> 
> For windows vms we need to create perset like this one [1]. We can add
> separator
> 
> ---
> 
> between the objects.

I'm a bit confused about the second part.  Is the VirtualMachinePreset
file a separate file from the .yaml file that we're creating already
or is it a replacement for it?

We can create as many files as needed, or create different files
depending on the machine type, or whatever is needed.

Anyway I was hoping you'd take this patch and run with it.  Certainly
the osinfo part (which I just made up on the spot) is dead simple to
change.  You can post patches on this mailing list (eg. using ‘git
send-email’) and we can review them together.

Rich.

> Thanks,
> Piotr
> 
> [1]
> https://github.com/kubevirt/kubevirt/blob/master/manifests/release/demo-content.yaml.in
> 
> 
> 
> On Tue, Mar 27, 2018 at 6:31 PM, Richard W.M. Jones <rjones at redhat.com>
> wrote:
> 
> > Fixes some of the more egregious problems with v1, and also
> > applies properly to the head of git without needing any other
> > patches.
> >
> > Rich.
> >
> >

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list