[Libguestfs] [PATCH] appliance: initialize the appliance_files struct

Pino Toscano ptoscano at redhat.com
Fri May 4 13:55:35 UTC 2018


Some compilers do not manage to figure out that the members of it are
set only when search_appliance() in the end returns 1, which is already
checked.  Help them a bit by resetting the appliance_files struct on our
own, so they will not report that 'appliance.kernel', and the others are
used as uninitialized.
---
 lib/appliance.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/appliance.c b/lib/appliance.c
index 360d4105f..0fa37339e 100644
--- a/lib/appliance.c
+++ b/lib/appliance.c
@@ -118,6 +118,8 @@ guestfs_int_build_appliance (guestfs_h *g,
 
   struct appliance_files appliance;
 
+  memset (&appliance, 0, sizeof appliance);
+
   if (search_appliance (g, &appliance) != 1)
     return -1;
 
-- 
2.14.3




More information about the Libguestfs mailing list