[Libguestfs] [PATCH] Fix building on macOS

[Adam Robinson]

Hi Richard,
rpc/xdr.h does not itself include rpc/types.h on macOS.  This is why I had
to modify the configure script to check for rpc/types.h and include it when
checking for rpc/xdr.h.  Without this, the configure script throws up
a "WARNING: rpc/xdr.h: present but cannot be compiled" and fails.

What is also was interesting is that some files (such as lib/proto.c)
already include the headers in this order.


Thanks,
-Adam

On Mon, May 7, 2018 at 4:04 PM, Richard W.M. Jones <rjones at redhat.com>
wrote:

> diff --git a/daemon/tsk.c b/daemon/tsk.c
> index ad10d74fe..00a4b04b4 100644
> --- a/daemon/tsk.c
> +++ b/daemon/tsk.c
> @@ -23,8 +23,8 @@
>  #include <inttypes.h>
>  #include <string.h>
>  #include <unistd.h>
> -#include <rpc/xdr.h>
>  #include <rpc/types.h>
> +#include <rpc/xdr.h>
>
> Is it generally required on Macs that rpc/xdr.h is included after
> rpc/types.h, or is this change a mistake?
>
> The rest of the change looks fine.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~
> rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> Fedora Windows cross-compiler. Compile Windows programs, test, and
> build Windows installers. Over 100 libraries supported.
> http://fedoraproject.org/wiki/MinGW
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20180507/bb2c747c/attachment.htm>