[Libguestfs] [PATCH] lib: Increase default memory assigned to the appliance.

Richard W.M. Jones rjones at redhat.com
Wed May 16 12:47:28 UTC 2018


On Wed, May 16, 2018 at 01:43:09PM +0100, Richard W.M. Jones wrote:
> With recent Linux kernels, adding and partitioning 255 disks causes
> the appliance to run out of memory.  This causes a test failure in
> tests/disks/test-255-disks.sh.  This change gives the appliance enough
> memory to complete the test.
> ---
>  lib/guestfs-internal.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h
> index adeb9478a..83eaebe75 100644
> --- a/lib/guestfs-internal.h
> +++ b/lib/guestfs-internal.h
> @@ -94,7 +94,7 @@
>   * creating device nodes.
>   */
>  #ifdef __powerpc__
> -#  define DEFAULT_MEMSIZE 768
> +#  define DEFAULT_MEMSIZE 1024
>  #  define MIN_MEMSIZE 256

We could also remove this definition of MIN_MEMSIZE, and ...

>  #endif
>  
> @@ -104,16 +104,16 @@
>   * common on aarch64, treat this like the ppc case above.
>   */
>  #ifdef __aarch64__
> -#  define DEFAULT_MEMSIZE 768
> +#  define DEFAULT_MEMSIZE 1024
>  #  define MIN_MEMSIZE 256

... this one too since it will be set below.

>  #endif
>  
>  /* The default and minimum memory size for most users. */
>  #ifndef DEFAULT_MEMSIZE
> -#  define DEFAULT_MEMSIZE 500
> +#  define DEFAULT_MEMSIZE 768
>  #endif
>  #ifndef MIN_MEMSIZE
> -#  define MIN_MEMSIZE 128
> +#  define MIN_MEMSIZE 256
>  #endif

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list