[Libguestfs] [PATCH v3 4/4] lib, p2v: Use single_element() macro where possible.

Richard W.M. Jones rjones at redhat.com
Fri Nov 2 19:43:36 UTC 2018


On Fri, Nov 02, 2018 at 05:15:47PM +0100, Pino Toscano wrote:
> > -      if (params->data->uefi_vars) {
> > -	start_element ("nvram") {
> > -	  string (params->data->uefi_vars);
> > -	} end_element ();
> > -      }
> > +      if (params->data->uefi_vars)
> > +	single_element ("nvram", params->data->uefi_vars);
> 
> Hm indented with tab?

As spaces/tabs are used very inconsistently in this file, and as emacs
is actually using spaces for indentation, I committed another patch on
top to fix the tab/spaces issue in this one file:

https://github.com/libguestfs/libguestfs/commit/b0daa89ef06fc68b2b1c10aa6b7a3644ac5403f5

I'm not clear how the file got this way.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list