[Libguestfs] [PATCH v3 0/3] Install QEMU-GA from oVirt guest tools ISO on Linux
Tomáš Golembiovský
tgolembi at redhat.com
Wed Nov 7 17:49:02 UTC 2018
On Wed, 7 Nov 2018 17:32:56 +0100
Tomáš Golembiovský <tgolembi at redhat.com> wrote:
> On Wed, 7 Nov 2018 15:31:56 +0000
> "Richard W.M. Jones" <rjones at redhat.com> wrote:
>
> > On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> > > changes in v3:
> > > - fix call to install_local
> > >
> > > changes in v2:
> > > - moved copy_drivers above copy_files
> > > - renamed copy_files to copy_from_virtio_win
> > > - renamed install to install_local
> > > - use rpm instead of yum
> > >
> > > This installs packages with QEMU Guest Agent when converting Linux machine. The
> > > packages should be available on guest tools ISO. The patches work "as-is" but
> > > probably deserve some more attention:
> > >
> > > - it is "abusing" Winows_virtio code but renaming/refactoring everything to
> > > remove "windows" from the name and use "guest tools" seems like a lot of
> > > unnecesary work
> >
> > I didn't mean the comment to mean it was abusing Windows_virtio. It
> > was just a surprise since at the moment Convert_windows is the only
> > consumer of the Windows_virtio code. However the change is still
> > correct so this doesn't matter, and maybe we can rename the module in
> > future.
>
> This was in cover letter before your comment. :)
>
> >
> > > - support for Debian is missing
> > > I don't know how to install the package only when all it's dependencies are
> > > already installed. dpkg cannot be used to check that (simulate the install).
> > > And attempting to install the package will leave it half-installed (dpkg
> > > cannot roll-back).
> >
> > Will we actually have Debian packages on the ISO?
>
> Yes.
>
> >
> > BTW do we actually have an example of the new ISO or virtio-win.rpm I
> > can test against?
>
> I am not sure if we have ISO for oVirt already. Let me check.
https://resources.ovirt.org/pub/ovirt-4.2/rpm/el7/noarch/ovirt-guest-tools-iso-4.2-4.el7.noarch.rpm
>
> Tomas
>
> >
> > Rich.
> >
> > > Tomáš Golembiovský (3):
> > > v2v: refactor copy_drivers() in Windows_virtio
> > > v2v: linux: install packages
> > > v2v: linux: install QEMU-GA (RHBZ#1619665)
> > >
> > > v2v/convert_linux.ml | 2 ++
> > > v2v/linux.ml | 14 ++++++++
> > > v2v/linux.mli | 3 ++
> > > v2v/windows_virtio.ml | 78 +++++++++++++++++++++++++++++++++---------
> > > v2v/windows_virtio.mli | 4 +++
> > > 5 files changed, 84 insertions(+), 17 deletions(-)
> > >
> > > --
> > > 2.19.0
> > >
> > > _______________________________________________
> > > Libguestfs mailing list
> > > Libguestfs at redhat.com
> > > https://www.redhat.com/mailman/listinfo/libguestfs
> >
> > --
> > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> > Read my programming and virtualization blog: http://rwmj.wordpress.com
> > virt-top is 'top' for virtual machines. Tiny program with many
> > powerful monitoring features, net stats, disk stats, logging, etc.
> > http://people.redhat.com/~rjones/virt-top
>
>
> --
> Tomáš Golembiovský <tgolembi at redhat.com>
--
Tomáš Golembiovský <tgolembi at redhat.com>
More information about the Libguestfs
mailing list