[Libguestfs] [PATCH 0/2] build: Replace ./nbdkit with a C program.
Richard W.M. Jones
rjones at redhat.com
Tue Nov 13 22:51:28 UTC 2018
This patch series solves the FreeBSD shebang problem in a completely
different way, and a few other things besides. I propose that we
replace ./nbdkit with a C program. The C program is a straightforward
translation of the shell script.
Some advantages of this approach are:
- We can parse options in exactly the same way as the real program.
- Use the more accurate ‘is_short_name’ test for unadorned
plugin/filter names on the command line.
- Fixes the FreeBSD problem with shebangs caused because FreeBSD
refuses the use a shell script as a shebang path.
- No longer need to maintain that troublesome shell script.
I have verified that this does indeed fix the FreeBSD shebang problem
(but didn't test on Haiku). It also passes 'make check' and
'make check-valgrind' on Linux.
More information about the Libguestfs