[Libguestfs] [PATCH v3] v2v: -o openstack: Allow -oo insecure (RHBZ#1651432).

[Tomáš Golembiovský]

On Tue, 20 Nov 2018 10:25:10 +0000
"Richard W.M. Jones" <rjones at redhat.com> wrote:

> Previously we allowed arbitrary flags to be passed through to the
> underlying openstack CLI command, provided they have the format
> ‘--key=value’.  We want to pass the ‘--insecure’ flag through, but
> that doesn't have the key=value form.  However a small modification to
> the matching rules would allow this.
> 
> The effect of this change is that you can now use ‘virt-v2v -oo
> insecure’ to turn off SSL certificate validation.  The default is to
> verify the server certificate (which is the default of the openstack
> command).
> ---
>  v2v/output_openstack.ml           | 11 +++++++----
>  v2v/test-v2v-o-openstack.sh       |  2 ++
>  v2v/virt-v2v-output-openstack.pod |  7 +++++++
>  3 files changed, 16 insertions(+), 4 deletions(-)
> 

LGTM

I would just enhance the commit message little bit. The change allows
you to pass arbitrary argument and not just --insecure. E.g. --validate
(the opposite of --insecure) or --debug and --verbose.