[Libguestfs] [PATCH] v2v: Add support for libosinfo metadata

Richard W.M. Jones rjones at redhat.com
Fri Nov 23 15:27:24 UTC 2018

On Fri, Nov 23, 2018 at 03:55:15PM +0100, Martin Kletzander wrote:
> On Fri, Nov 23, 2018 at 02:26:08PM +0100, Martin Kletzander wrote:
> >On Fri, Nov 23, 2018 at 01:16:55PM +0000, Richard W.M. Jones wrote:
> >>On Fri, Nov 23, 2018 at 02:10:01PM +0100, Martin Kletzander wrote:
> [...]
> >>>   I haven't find any unit tests for these kind of functions, so no
> >>>   tests are added.  If there is a place where tests would fit
> >>>   nicely, feel free to let me know.
> >>
> >>... I think the tests might actually be broken by this patch.  Did you
> >>try: ‘make -C test-data check && make -C v2v check’?
> >>
> >
> >good point, probably not after the patch. will do.
> >
> The tests pass.  Should I add/change something in there as well since I'm going
> to be sending v2 anyway?

I see that the test I was expecting might fail (test-v2v-o-libvirt.sh)
in fact only uploads the XML to libvirt without checking it in detail,
and we don't have a test for -o local at all.

Nevermind.  Just post patch v2.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.

More information about the Libguestfs mailing list