[Libguestfs] [PATCH 3/3] lib: inspect: tweak limits of package manager files

Pino Toscano ptoscano at redhat.com
Fri Nov 30 12:07:49 UTC 2018


Tweak the limits of the files of package managers downloaded to list the
installed applications:
- bump RPM 'Packages' up to 500M: Fedora installations upgraded to each
  new Fedora release have an ever-growing file, reported to be even
  slightly bigger than 400M
- reduce the other files down to 50M: they are usually small, not bigger
  than 1M-5M, so 50M is a good enough high threshold
---
 lib/inspect-apps.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c
index 3441b4b94..dbc9d968c 100644
--- a/lib/inspect-apps.c
+++ b/lib/inspect-apps.c
@@ -50,15 +50,15 @@
 /* Maximum RPM 'Packages' file we will download to /tmp.  This file
  * can get very large: 70 MB is roughly the standard size for a new
  * Fedora install, and after lots of package installation/removal
- * I have seen well over 100 MB databases.
+ * I have seen well over 400 MB databases.
  */
-#define MAX_RPM_PACKAGES_SIZE          (300 * 1000 * 1000)
+#define MAX_RPM_PACKAGES_SIZE          (500 * 1000 * 1000)
 /* Maximum RPM 'Name' file we will download to /tmp. */
-#define MAX_RPM_NAME_SIZE              (300 * 1000 * 1000)
+#define MAX_RPM_NAME_SIZE              (50 * 1000 * 1000)
 /* Maximum dpkg 'status' file we will download to /tmp. */
-#define MAX_DPKG_STATUS_SIZE           (300 * 1000 * 1000)
+#define MAX_DPKG_STATUS_SIZE           (50 * 1000 * 1000)
 /* Maximum APK 'installed' file we will download to /tmp. */
-#define MAX_APK_INSTALLED_SIZE         (300 * 1000 * 1000)
+#define MAX_APK_INSTALLED_SIZE         (50 * 1000 * 1000)
 
 #ifdef DB_DUMP
 static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root);
-- 
2.17.2




More information about the Libguestfs mailing list