[Libguestfs] [PATCH v4 0/3] Install QEMU-GA from oVirt guest tools ISO on Linux

Tomáš Golembiovský tgolembi at redhat.com
Tue Nov 13 14:01:05 UTC 2018


On Tue, 13 Nov 2018 13:41:39 +0100
Tomáš Golembiovský <tgolembi at redhat.com> wrote:

> changes in v4:
> - fix call to install_local

v3 was same as v2 because I forgot to commit the changes. 
The difference between v2 and v4 is just one line in the
Linux.install_local call.

    Tomas

> 
> changes in v2:
> - moved copy_drivers above copy_files
> - renamed copy_files to copy_from_virtio_win
> - renamed install to install_local
> - use rpm instead of yum
> 
> This installs packages with QEMU Guest Agent when converting Linux machine. The
> packages should be available on guest tools ISO. The patches work "as-is" but
> probably deserve some more attention:
> 
> - it is "abusing" Winows_virtio code but renaming/refactoring everything to
>   remove "windows" from the name and use "guest tools" seems like a lot of
>   unnecesary work
> 
> - support for Debian is missing
>   I don't know how to install the package only when all it's dependencies are
>   already installed. dpkg cannot be used to check that (simulate the install).
>   And attempting to install the package will leave it half-installed (dpkg
>   cannot roll-back).
> 
> Tomáš Golembiovský (3):
>   v2v: refactor copy_drivers() in Windows_virtio
>   v2v: linux: install packages
>   v2v: linux: install QEMU-GA (RHBZ#1619665)
> 
>  v2v/convert_linux.ml   |  2 ++
>  v2v/linux.ml           | 14 ++++++++
>  v2v/linux.mli          |  3 ++
>  v2v/windows_virtio.ml  | 78 +++++++++++++++++++++++++++++++++---------
>  v2v/windows_virtio.mli |  4 +++
>  5 files changed, 84 insertions(+), 17 deletions(-)
> 
> -- 
> 2.19.1
> 


-- 
Tomáš Golembiovský <tgolembi at redhat.com>




More information about the Libguestfs mailing list