[Libguestfs] [PATCH nbdkit v2 3/3] xz: tests: Use a very small block size in test disk.

Richard W.M. Jones rjones at redhat.com
Wed Nov 21 19:00:44 UTC 2018


A better test of edge cases which occur between blocks.  In fact this
change found two bugs while developing the xz filter (not present in
the plugin).
---
 tests/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 0cd2366..e9b01f2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -741,7 +741,9 @@ test_xz_LDADD = libtest.la $(LIBGUESTFS_LIBS)
 
 disk.xz: disk
 	rm -f $@
-	xz --best --block-size=16777216 -c disk > $@
+# We choose a very small block size here only for testing.  Normally
+# you should choose a 16M block size.
+	xz --best --block-size=32768 -c disk > $@
 
 endif HAVE_GUESTFISH
 endif HAVE_LIBLZMA
-- 
2.19.0.rc0




More information about the Libguestfs mailing list