[Libguestfs] [PATCH] ocaml: make sure to pass LDFLAGS to ocamlmklibs linker (RHBZ#1624130)

Richard W.M. Jones rjones at redhat.com
Thu Sep 27 14:07:30 UTC 2018


On Thu, Sep 27, 2018 at 03:53:18PM +0200, Pino Toscano wrote:
> Pass the LDFLAGS properly as arguments for the C linker when using
> ocamlmklibs via the -ldopt option.
> 
> Followup of commit 34c23403c51a4d59d826c8045e06f9aabc2ceb16.
> ---
>  ocaml/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am
> index 752fc109c..4d13eed97 100644
> --- a/ocaml/Makefile.am
> +++ b/ocaml/Makefile.am
> @@ -64,14 +64,14 @@ endif
>  
>  stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm)
>  	$(OCAMLMKLIB) -o mlguestfs \
> +	  -ldopt '$(LDFLAGS)' \
>  	  $(libguestfsocaml_a_OBJECTS) guestfs.cmo \
> -	  $(LDFLAGS) \
>  	  $(LTLIBINTL) \
>  	  -L../lib/.libs -lguestfs
>  if HAVE_OCAMLOPT
>  	$(OCAMLMKLIB) -o mlguestfs \
> +	  -ldopt '$(LDFLAGS)' \
>  	  $(libguestfsocaml_a_OBJECTS) guestfs.cmx \
> -	  $(LDFLAGS) \
>  	  $(LTLIBINTL) \
>  	  -L../lib/.libs -lguestfs
>  endif

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html




More information about the Libguestfs mailing list