[Libguestfs] [nbdkit PATCH 0/7] Implement structured replies in nbd plugin

Eric Blake eblake at redhat.com
Tue Apr 23 00:50:19 UTC 2019


I'm hoping to implement .extents for the nbd plugin; this is a
prerequisite. I'm not sure about patch 3 - if we like it, I'll
squash it to 2, if we don't, I think we are okay just dropping
it. I'm also wondering if we have to worry about malicious
plugins that don't populate the entire .pread buffer in an
effort to get nbdkit to expose portions of the heap; my patch 7
loses some time on extra memset()s to avoid that, although it's
probably in the noise compared to the time spent talking over
sockets to the remote server.

Eric Blake (7):
  protocol: Send correct structured reply error for non-Linux
  protocol: Support EOVERFLOW
  RFC: protocol: Only send EOVERFLOW when valid
  nbd: Honor server global flags on little-endian
  protocol: Add helpers for error response handling
  nbd: Implement NBD_OPT_GO client request
  nbd: Implement structured replies

 common/protocol/protocol.h |  21 +-
 plugins/nbd/nbd.c          | 434 +++++++++++++++++++++++++++++++++----
 server/protocol.c          |  16 +-
 3 files changed, 422 insertions(+), 49 deletions(-)

-- 
2.20.1




More information about the Libguestfs mailing list