[Libguestfs] guestfish Remote Images IPv6 Support

[Richard W.M. Jones]

On Mon, Apr 01, 2019 at 11:23:28AM -0500, Jonathan Wright wrote:
> This worked wonderfully!  What are the odds of getting this upstream
> in the near future?  I'd rather not build from source in production.

Thanks for testing, I'll push it upstream now and backport
it to 1.40 in the near future.

Rich.

> # ./run guestfish --format=raw --ro -a
> rbd://[fd00::cefc:1]:6789/images/CentOS-7-x86_64-GenericCloud-1901
> libguestfs: trace: set_verbose true
> libguestfs: trace: set_verbose = 0
> libguestfs: trace: set_tmpdir "/root/libguestfs/tmp"
> libguestfs: trace: set_tmpdir = 0
> libguestfs: trace: set_cachedir "/root/libguestfs/tmp"
> libguestfs: trace: set_cachedir = 0
> libguestfs: trace: set_path "/root/libguestfs/appliance"
> libguestfs: trace: set_path = 0
> libguestfs: create: flags = 0, handle = 0xf4afb0, program = guestfish
> libguestfs: trace: set_pgroup true
> libguestfs: trace: set_pgroup = 0
> libguestfs: trace: add_drive
> "images/CentOS-7-x86_64-GenericCloud-1901" "readonly:true"
> "format:raw" "protocol:rbd" "server:tcp:[fd00::cefc:1]:6789"
> libguestfs: creating COW overlay to protect original drive content
> libguestfs: trace: get_tmpdir
> libguestfs: trace: get_tmpdir = "/root/libguestfs/tmp"
> libguestfs: trace: disk_create
> "/root/libguestfs/tmp/libguestfs9gclsg/overlay1.qcow2" "qcow2" -1 "backingfile:rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00\:\:cefc\:1]\:6789:auth_supported=none"
> "backingformat:raw"
> libguestfs: command: run: qemu-img
> libguestfs: command: run: \ create
> libguestfs: command: run: \ -f qcow2
> libguestfs: command: run: \ -o backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00\:\:cefc\:1]\:6789:auth_supported=none,backing_fmt=raw
> libguestfs: command: run: \
> /root/libguestfs/tmp/libguestfs9gclsg/overlay1.qcow2
> Formatting '/root/libguestfs/tmp/libguestfs9gclsg/overlay1.qcow2',
> fmt=qcow2 size=8589934592 backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00\:\:cefc\:1]\:6789:auth_supported=none
> backing_fmt=raw cluster_size=65536 lazy_refcounts=off
> refcount_bits=16
> libguestfs: trace: disk_create = 0
> libguestfs: trace: add_drive = 0
> 
> Welcome to guestfish, the guest filesystem shell for
> editing virtual machine filesystems and disk images.
> 
> Type: ‘help’ for help on commands
>       ‘man’ to read the manual
>       ‘quit’ to quit the shell
> 
> ><fs> quit
> 
> libguestfs: trace: shutdown
> libguestfs: trace: shutdown = 0
> libguestfs: trace: close
> libguestfs: closing guestfs handle 0xf4afb0 (state 0)
> libguestfs: command: run: rm
> libguestfs: command: run: \ -rf /root/libguestfs/tmp/libguestfs9gclsg
> 
> On 4/1/19 10:45 AM, Richard W.M. Jones wrote:
> >On Mon, Apr 01, 2019 at 09:45:56AM -0500, Jonathan Wright wrote:
> >>I believe the bug lies in libguestfs.
> >>
> >>Taking out the commands being sent to QEMU and using qemu-img info I
> >>can recreate the error:
> >>
> >># qemu-img info "rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none"
> >>qemu-img: Could not open 'rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none':
> >>invalid conf option :cefc:1]:6789:auth_supported: No such file or
> >>directory
> >>
> >>When escaping the : in the v6 address (just like is done with the
> >>port's : ) the command works as expected.
> >Ah I see.  Can you try the small patch attached?
> >
> >Rich.
> >
> -- 
> Jonathan Wright
> KnownHost, LLC
> https://www.knownhost.com

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org