[Libguestfs] [PATCH v4 3/7] v2v: switch to ocaml-libvirt

Richard W.M. Jones rjones at redhat.com
Wed Apr 10 13:16:15 UTC 2019


On Mon, Apr 08, 2019 at 02:49:56PM +0200, Pino Toscano wrote:
> +  let lazy_conn =

Can we call this just ‘conn’ (or ‘libvirt_conn’)?  Laziness is implied
by the type.  There's another one in Parse_libvirt_xml too.

I didn't check in detail that we reproduce every last feature of the
old C bindings, but it seems as if we are doing so.

ACK (with variable name change).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list