[Libguestfs] [nbdkit PATCH 4/8] Revert "RHEL 5: Define O_CLOEXEC and SOCK_CLOEXEC."

[Eric Blake]

On 8/1/19 4:15 AM, Richard W.M. Jones wrote:
> On Thu, Aug 01, 2019 at 10:06:01AM +0100, Richard W.M. Jones wrote:
>> As far as I can see Haiku (hrev52698) has O_CLOEXEC but NOT
>> SOCK_CLOEXEC.  As this version is a little old I'll do an update and
>> see if newer versions support it.
> 
> I'm on hrev53313+1 which also doesn't appear to have SOCK_CLOEXEC (nor
> does it have accept4).

Ouch. Then I'm seriously thinking of a followup patch which either
forces SERIALIZE_ALL_REQUESTS on all plugins when SOCK_CLOEXEC is
missing, or which adds a bool to the plugin interface that the plugin
sets to true if it does not fork (default to false), and where we force
SERIALIZE_ALL_REQUESTS plugins which have not set it to true (most of
our in-tree plugins can set the bool to true).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190801/6eca7f59/attachment.sig>