[Libguestfs] [PATCH disk-sync 2/5] Rearrange nbdkit parameters.

Richard W.M. Jones rjones at redhat.com
Thu Aug 22 14:39:32 UTC 2019


No real change here, but:

 * Put the -s and --exit-with-parent options first.  Keep filters and
   plugin together.

 * Remove --newstyle option, it's not needed in any sufficiently
   recent version.
---
 wrapper/disk_sync.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/wrapper/disk_sync.py b/wrapper/disk_sync.py
index 42fbbaf..55f2ba9 100644
--- a/wrapper/disk_sync.py
+++ b/wrapper/disk_sync.py
@@ -354,13 +354,12 @@ def get_nbdkit_cmd(disk, key):
         'env',
         env,
         'nbdkit',
+        '-s',
+        '--exit-with-parent',
         '--readonly',
-        '--newstyle',
         '--exportname=/',
-        '-s',
         '--filter=log',
         '--filter=cacheextents',
-        '--exit-with-parent',
         'vddk',
         'libdir=%s' % VDDK_LIBDIR,
         'vm=moref=' + state['vm_moid'],
-- 
2.22.0




More information about the Libguestfs mailing list