[Libguestfs] [nbdkit PATCH 6/9] server: Cache per-connection can_FOO flags

[Richard W.M. Jones]

On Thu, Aug 29, 2019 at 10:08:26PM -0500, Eric Blake wrote:
> @@ -232,8 +257,8 @@ handle_request (struct connection *conn,
>                  void *buf, struct nbdkit_extents *extents)
>  {
>    uint32_t f = 0;
> -  bool fua = conn->can_fua && (flags & NBD_CMD_FLAG_FUA);
>    int err = 0;
> +  int r;
> 
>    /* Clear the error, so that we know if the plugin calls
>     * nbdkit_set_error() or relied on errno.  */
> @@ -246,7 +271,7 @@ handle_request (struct connection *conn,
>      break;
> 
>    case NBD_CMD_WRITE:
> -    if (fua)
> +    if (flags & NBD_CMD_FLAG_FUA)
>        f |= NBDKIT_FLAG_FUA;

So don't we need to keep the backend_can_fua() test here and later in
this function?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v