[Libguestfs] [nbdkit PATCH 2/2] plugins: Permit ENOTSUP as synonym for EOPNOTSUPP

[Richard W.M. Jones]

On Mon, Aug 12, 2019 at 10:10:07PM -0500, Eric Blake wrote:
> index 9df5001d..a9d6491a 100644
> --- a/plugins/file/file.c
> +++ b/plugins/file/file.c
> @@ -73,6 +73,12 @@ static pthread_mutex_t lseek_lock = PTHREAD_MUTEX_INITIALIZER;
>  /* to enable: -D file.zero=1 */
>  int file_debug_zero;
> 
> +static bool
> +file_is_enotsup (int err)
> +{
> +  return err == ENOTSUP || err == EOPNOTSUPP;
> +}

Series is fine, but I'd probably have called this function just
"is_enotsup".  We have usually reserved the <plugin>_ prefix for
the callback functions themselves, not random helper functions
in the plugin.

ACK

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/