[Libguestfs] [PATCH libnbd 4/6] lib: Check Closure parameter is not NULL.

Richard W.M. Jones rjones at redhat.com
Tue Aug 13 13:19:21 UTC 2019


On Tue, Aug 13, 2019 at 06:26:31AM -0500, Eric Blake wrote:
> The generator has a check that:
> 
>     (* !may_set_error is incompatible with String parameters because
>      * we have to do a NULL-check on those which may return an error.
>      *)
> 
> Should this check be widened to cover Closure, so that we get a nicer
> error than 'assert false' if someone goofs in adding a new signature
> that uses Closure with the wrong return type?  Can be a separate patch,
> since we missed doing it for Enum and Flags in earlier patches, which
> also are instances where we used 'assert false' and require the ability
> to return an error.  Doesn't affect runtime correctness, just
> ease-of-use when re-compiling changes to the generator.

Yes this check was buggy in several ways.  I'll fix
this (in a separate commit) and update this commit
before I push it.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW




More information about the Libguestfs mailing list