[Libguestfs] [PATCH libnbd] docs: Change docs/Makefile.inc back to a regular include, readd to git.

[Eric Blake]

On 8/15/19 7:50 AM, Richard W.M. Jones wrote:
> ‘make clean && make’ was not rebuilding the docs/*.3 files.  The
> reason is obscure:
> 
>  - docs/Makefile has rules:
> 
>    MANS = $(man_MANS)
>    all: all-am
>    all-am: Makefile $(MANS)
> 
>  - sinclude docs/Makefile.inc happened long after MANS is defined, so
>    MANS held the earlier version of $(man_MANS) without the api-built
>    man pages listed.
> 
> This was confirmed by looking at the output of ‘make -d -C docs all-am’
> and examining what happens when rebuilding all-am.
> 
> The fix is to change docs/Makefile.inc back to a regular include,
> which also means we have to readd this generated file to git to allow
> cold clones to work.
> 
> Partly reverts commit 15ca7acd6f46188d6f713af8785e35336b0b71f7.
> ---
>  .gitignore          |  1 -
>  docs/Makefile.am    |  8 +---
>  docs/Makefile.inc   | 98 +++++++++++++++++++++++++++++++++++++++++++++
>  generator/generator |  2 +-
>  4 files changed, 100 insertions(+), 9 deletions(-)

I'm still experimenting to see if we can avoid this with use of

$(MAKECMDGOALS): Makefile.inc

or similar.  Hold off on this one for a bit longer.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190815/a8f6d046/attachment.sig>