[Libguestfs] [nbdkit PATCH] nbd: Another libnbd version bump
Eric Blake
eblake at redhat.com
Thu Aug 15 16:14:23 UTC 2019
On 8/15/19 10:37 AM, Richard W.M. Jones wrote:
> On Thu, Aug 15, 2019 at 09:27:14AM -0500, Eric Blake wrote:
>> The 0.9.8 release breaks API, requiring a number of changes:
>> - Use symbolic constants instead of magic numbers/open-coded strings
>> (well, the string for "base:allocation" was present before this
>> libnbd bump)
>> - Change callbacks to drop the valid_flag parameter
>> - Add _is to nbd_read_only call
>> - Drop the _callback suffix on nbd_aio_FOO calls
>> - Add a struct for managing callback/user_data at once
>
> Seems reasonable.
>
>> @@ -160,11 +160,12 @@ nbdplug_config (const char *key, const char *value)
>> if (strcasecmp (value, "require") == 0 ||
>> strcasecmp (value, "required") == 0 ||
>> strcasecmp (value, "force") == 0)
>> - tls = 2;
>> + tls = LIBNBD_TLS_REQUIRE;
>> else {
>> - tls = nbdkit_parse_bool (value);
>> - if (tls == -1)
>> + r = nbdkit_parse_bool (value);
>> + if (r == -1)
>> exit (EXIT_FAILURE);
>> + tls = r ? LIBNBD_TLS_ALLOW : LIBNBD_TLS_DISABLE;
For this patch, it was straight conversion. If we change things, that
belongs in a separate patch.
>
> Our feedback was the LIBNBD_TLS_ALLOW was really bad (I'm unconvinced
> because I prefer my stuff to work and TLS very often doesn't). Do you
> think we should use REQUIRE here as well?
The existing behavior of 'nbd tls=...' matches the 'nbdkit --tls=...'
behavior. Whether to keep both options as tri-state, or whether to make
'--tls=on'/'--tls=yes' default to strict, and add yet another spelling
for '--tls=optional' as something that is harder to spell for the
specific case when you are willing to open yourself to
man-in-the-middle, may have merit.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190815/cb1e2d79/attachment.sig>
More information about the Libguestfs
mailing list