[Libguestfs] [PATCH nbdkit] freebsd: In nbdkit_nanosleep, fallback to calling nanosleep(2).

[Richard W.M. Jones]

On Wed, Aug 28, 2019 at 12:02:44PM -0500, Eric Blake wrote:
> On 8/28/19 11:14 AM, Richard W.M. Jones wrote:
> > Rather than failing to compile on platforms which lack POLLRDHUP such
> > as FreeBSD, simply fallback to the old method of sleeping.
> > 
> > This leaves the porting suggestions as a comment in case someone wants
> > to implement a better solution for particular platforms.
> > ---
> >  server/public.c | 38 ++++++++++++++++++++++++--------------
> >  1 file changed, 24 insertions(+), 14 deletions(-)
> 
> This means 'make check' will fail on FreeBSD; do we have a way to
> introspect whether a platform lacks POLLRDHUP this is the case, to skip
> rather than fail tests/test-shutdown.sh on those platforms?
> 
> At any rate, the fallback is reasonable, even if underwhelming in
> performance, so ACK.

Thanks.  I'm going to push this.

The current situation on FreeBSD (11.1-RELEASE) is that a lot of tests
fail including this one.  I'm currently (and very slowly) upgrading to
12.0-RELEASE which may have a newer qemu which should fix most of the
failures, and if there's an easy way to fix this test for FreeBSD then
I'll do that later.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v