[Libguestfs] [nbdkit PATCH 1/9] server: Fewer dereferences in filter

Richard W.M. Jones rjones at redhat.com
Fri Aug 30 13:03:36 UTC 2019


On Thu, Aug 29, 2019 at 10:08:21PM -0500, Eric Blake wrote:
> Anywhere that we compute 'f = container_of(b)' then use 'f->backend.',
> we can instead just use 'b->'.  Similarly, during registration, we can
> use the 'filename' input rather than our just-copied 'f->filename'.

This essentially follows from the definition of container_of.

I couldn't spot any mistakes in the changes below, and in any case
strong typing should prevent mistakes.

So yes, ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list