[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 6/6] rust: fix list of generator-built files



On Friday, 13 December 2019 15:42:06 CET Richard W.M. Jones wrote:
> On Thu, Dec 12, 2019 at 06:05:05PM +0100, Pino Toscano wrote:
> > src/lib.rs is not created by the generator, while src/guestfs.rs is.
> > ---
> >  rust/Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rust/Makefile.am b/rust/Makefile.am
> > index edcccffa1..cb16e021f 100644
> > --- a/rust/Makefile.am
> > +++ b/rust/Makefile.am
> > @@ -19,7 +19,7 @@ include $(top_srcdir)/subdir-rules.mk
> >  
> >  generator_built = \
> >  	src/bin/bindtests.rs \
> > -	src/lib.rs
> > +	src/guestfs.rs
> >  
> >  EXTRA_DIST = \
> >  	$(generator_built) \
> 
> ACK series.  Up to you what you want to do about patch 1.

In the end I decided to push it, because the situation is already broken
without the fix to subdir-rules.mk. So at least let's fail earlier,
rather pretending to build while it will not work in the end.
Also, the issue happens only on builddir!=srcdir builds.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]