[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions



> > + * Note that the call may succeed whithout copying any file at all. This may
> > + * happen when the source subdirectory exists but is empty or when [filter]
> > + * function is too strict to allow any of the files.  
> 
> Not sure why copy_from_virtio_win should allow an empty list as srcdirs.
> IMHO it seems better to have it error out on an empty list.
> 

This is not what I am trying to say there. What I am trying to say is:
you pass non-empty [srcdirs] and there is a matching directory that
fits that request; if this directory contains no files then the call
itself succeeds (because some directory was found) but no files were
copied.

Let me know if you have tips on how to phrase that better.

    Tomas


-- 
Tomáš Golembiovský <tgolembi redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]