[Libguestfs] [nbdkit PATCH 0/2] Another libnbd API bump

Eric Blake eblake at redhat.com
Wed Jul 17 02:43:37 UTC 2019


libnbd 0.1.7 was released today, which breaks compilation of
nbdkit-nbd-plugin. We could work around it by using #ifdef
LIBNBD_HAVE_XXX to learn about the renamed functions, but supporting
older versions is not all that important when we don't yet have API
stability.  So patch 1 copes by just bumping the minimum version
instead, except that we have yet another pending libnbd patch with an
API break - and those changes are trickier (reordering parameters does
NOT create a new LIBNBD_HAVE_XXX witness macro, so you can't easily
compile for 0.1.7 and 0.1.8 at the same time), so I'm leaning more
towards doing nothing until libnbd 0.1.8 is released and then
squashing these together (as that shouldn't be much longer).  If
short-term compilation is needed without these patches, change
PKG_CHECK_MODULES to request [libnbd = 0.1.6] instead of >= (to
gracefully fall back to non-libnbd compilation if you don't have
libnbd 0.1.6 around).

Eric Blake (2):
  nbd: Another libnbd API bump
  nbd: Another libnbd API bump

 configure.ac      |  4 ++--
 plugins/nbd/nbd.c | 31 ++++++++++++++++---------------
 2 files changed, 18 insertions(+), 17 deletions(-)

-- 
2.20.1




More information about the Libguestfs mailing list