[Libguestfs] [PATCH libnbd v2 5/5] lib: Use unsigned for pread_structured status parameter.

Eric Blake eblake at redhat.com
Wed Jul 24 19:51:06 UTC 2019


On 7/24/19 2:03 PM, Richard W.M. Jones wrote:
> On Wed, Jul 24, 2019 at 01:43:23PM -0500, Eric Blake wrote:
>> On 7/24/19 11:54 AM, Richard W.M. Jones wrote:
>>> This is a bitmask so using an unsigned type is slightly safer.  This
>>> is not an ABI change since the types are compatible.
>>>

>> A bit of churn here that could have been squashed into patch 2.  But at
>> the end of the day, whether to spend more time polishing the patch when
>> the end result is fine is up to you.
>>
>> ACK series. I'll rebase my auto-retire patches on top of this once
>> you've pushed.
> 
> I think I need a bit more time on this series.  How about you
> push yours and I'll rebase this one on top of it.

Okay, mine is in.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190724/73f94215/attachment.sig>


More information about the Libguestfs mailing list