[Libguestfs] [PATCH libnbd 1/3] generator: Change Closure so it describes single callbacks.

Martin Kletzander mkletzan at redhat.com
Thu Jul 25 08:43:38 UTC 2019


On Wed, Jul 24, 2019 at 05:17:51PM +0100, Richard W.M. Jones wrote:
>On Wed, Jul 24, 2019 at 10:02:04AM -0500, Eric Blake wrote:
>> On 7/24/19 7:17 AM, Richard W.M. Jones wrote:
>> > +       pr "  py_args = Py_BuildValue (\"(\"";
>> > +       List.iter (
>> > +         function
>> > +         | ArrayAndLen (UInt32 n, len) -> pr " \"O\""
>> > +         | BytesIn (n, len) -> pr " \"y#\""
>> > +         | Int n -> pr " \"i\""
>> > +         | Int64 n -> pr " \"L\""
>> > +         | Mutable (Int n) -> pr " \"O\""
>> > +         | String n -> pr " \"s\""
>> > +         | UInt64 n -> pr " \"K\""
>> > +         (* The following not yet implemented for callbacks XXX *)
>> > +         | ArrayAndLen _ | Bool _ | BytesOut _
>> > +           | BytesPersistIn _ | BytesPersistOut _
>>
>> Not your usual indentation style.
>
>I think at some point I gave up fighting tuareg mode :-(
>
>I need to ask Martin for the right settings to make it indent in the
>preferred way.
>

So I only found this:

tuareg-electric-indent is a variable defined in ‘tuareg.el’.
Its value is nil

Documentation:
Whether to automatically indent the line after typing one of
the words in ‘tuareg-electric-indent-keywords’.  Lines starting
with ‘|’, ‘)’, ‘]‘, and ‘}’ are always indented when the
‘electric-indent-mode’ is turned on.

I did not change any tuareg settings from the default, neither can I find any in
the spacemacs ocaml layer, and I'm not using ocp-indent for the indentation when
typing (it is way different than the style used here).

So I tried whether it's related to the electric-indent-mode, but no matter
whether I disable or enable it, it does not change the alignment.

So I created new $HOME, ran `emacs -Q`, added melpa to the repository list,
installed tuareg and nothing else.  And it still Just Works™.  Maybe updating
your tuareg.el would do the trick? O:-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20190725/6cc004e3/attachment.sig>


More information about the Libguestfs mailing list