[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libnbd v3 1/2] lib: Implement closure lifetimes.



On Thu, Jul 25, 2019 at 10:43:05AM -0500, Eric Blake wrote:
> On 7/25/19 8:07 AM, Richard W.M. Jones wrote:
> > @@ -499,7 +499,7 @@
> >        /* Call the caller's extent function. */
> >        int error = cmd->error;
> >  
> > -      if (cmd->cb.fn.extent (cmd->cb.fn_user_data,
> > +      if (cmd->cb.fn.extent (LIBNBD_CALLBACK_VALID, cmd->cb.fn_user_data,
> >                               meta_context->name, cmd->offset,
> >                               &h->bs_entries[1], (length-4) / 4, &error) == -1)
> >          if (cmd->error == 0)
> 
> Hmm - no change to the FINISH state, which means you are relying on
> command retirement to free chunk/extent instead.  As long as that
> happens, we should be okay, though.

I didn't understand this one.  Is it wrong to add the VALID
flag here?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]